Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4981#discussion_r150020494
  
    --- Diff: flink-formats/flink-avro/pom.xml ---
    @@ -185,17 +185,6 @@ under the License.
                                                <configuration 
combine.self="override">
                                                        
<dependencyReducedPomLocation>${project.basedir}/target/dependency-reduced-pom.xml</dependencyReducedPomLocation>
                                                        
<promoteTransitiveDependencies>true</promoteTransitiveDependencies>
    --- End diff --
    
    We can probably remove the complete shading entry in that pom. Seem not to 
do anything anyways. Promoting transitive dependencies when nothing except 
`force-shading` is shaded into the jar should be a no-op. (theoretically, one 
never knows with the shade plugin ;-) )


---

Reply via email to