[ 
https://issues.apache.org/jira/browse/FLINK-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246472#comment-16246472
 ] 

ASF GitHub Bot commented on FLINK-8014:
---------------------------------------

GitHub user fhueske opened a pull request:

    https://github.com/apache/flink/pull/4990

    [FLINK-8014] [FLINK-8016] Add Kafka010JsonTableSink and documentation

    ## What is the purpose of the change
    
    - Adds a TableSink to write JSON-encoded rows to Kafka 0.10 topics
    - Adds documentation for KafkaJsonTableSinks
    
    ## Brief change log
    
    * Add Kafka010JsonTableSink
    * Enable flush on checkpoint to ensure at-least-once guarantees
    * Refactor tests for KafkaJsonTableSInks
    * Add documentation for KafkaJsonTableSinks
    
    ## Verifying this change
    
    * Tests have been added.
    * The sink uses a regular Kafka 0.10 producer
    * The SerializationSchema is separately tested
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **YES**
      - If yes, how is the feature documented? Documentation has been added to 
website


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fhueske/flink tableKafka10Sink

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4990.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4990
    
----
commit 937637b340ca02be770f040d94396b18bc9619d7
Author: Fabian Hueske <fhue...@apache.org>
Date:   2017-11-07T16:59:43Z

    [FLINK-8014] [table] Add Kafka010JsonTableSink.
    
    - Refactor KafkaTableSink tests.

commit b0fcc04229aac97a938fffdcdcad9b388cc37d72
Author: Fabian Hueske <fhue...@apache.org>
Date:   2017-11-09T14:07:17Z

    [FLINK-8016] [docs] Add documentation for KafkaJsonTableSinks.

----


> Add Kafka010JsonTableSink
> -------------------------
>
>                 Key: FLINK-8014
>                 URL: https://issues.apache.org/jira/browse/FLINK-8014
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>             Fix For: 1.4.0
>
>
> Offer a TableSource for JSON-encoded Kafka 0.10 topics but no TableSink.
> Since, the required base classes are already there, a 
> {{Kafka010JsonTableSink}} can be easily added. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to