[ 
https://issues.apache.org/jira/browse/FLINK-2591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14791826#comment-14791826
 ] 

ASF GitHub Bot commented on FLINK-2591:
---------------------------------------

Github user rmetzger commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1121#discussion_r39725238
  
    --- Diff: 
flink-yarn-tests/src/main/java/org/apache/flink/yarn/YARNSessionFIFOITCase.java 
---
    @@ -111,6 +111,20 @@ public void testClientStartup() {
        }
     
        /**
    +    * Test configuration parameter for default number of yarn containers
    +    */
    +   @Test
    +   public void testDefaultNumberOfTaskManagers() {
    +           LOG.info("Starting testDefaultNumberOfTaskManagers()");
    --- End diff --
    
    I would generate a flink-conf.yaml just for this test to test the behavior


> Add configuration parameter for default number of yarn containers
> -----------------------------------------------------------------
>
>                 Key: FLINK-2591
>                 URL: https://issues.apache.org/jira/browse/FLINK-2591
>             Project: Flink
>          Issue Type: Improvement
>          Components: YARN Client
>            Reporter: Robert Metzger
>            Assignee: Will Miao
>            Priority: Minor
>              Labels: starter
>
> A user complained about the requirement to always specify the number of yarn 
> containers (-n) when starting a job.
> Adding a configuration value with a default value will allow users to set a 
> default ;)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to