[ 
https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14803126#comment-14803126
 ] 

ASF GitHub Bot commented on FLINK-2613:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/1106#discussion_r39763329
  
    --- Diff: 
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
 ---
    @@ -212,6 +212,49 @@ class ScalaShellITSuite extends FunSuite with Matchers 
with BeforeAndAfterAll {
         out.toString + stdout
       }
     
    +  /**
    +   * tests flink shell startup with remote cluster (starts cluster 
internally)
    +   */
    +  test("start flink scala shell with remote cluster") {
    +
    +    val input: String = "val els = env.fromElements(\"a\",\"b\");\n" +
    --- End diff --
    
    Can you also add a check, that the program was actually executed for 
example by checking that the correct output was produced?


> Print usage information for Scala Shell
> ---------------------------------------
>
>                 Key: FLINK-2613
>                 URL: https://issues.apache.org/jira/browse/FLINK-2613
>             Project: Flink
>          Issue Type: Improvement
>          Components: Scala Shell
>    Affects Versions: 0.10
>            Reporter: Maximilian Michels
>            Assignee: Nikolaas Steenbergen
>            Priority: Minor
>              Labels: starter
>             Fix For: 0.10
>
>
> The Scala Shell startup script starts a {{FlinkMiniCluster}} by default if 
> invoked with no arguments.
> We should add a {{--help}} or {{-h}} option to make it easier for people to 
> find out how to configure remote execution. Alternatively, we could print a 
> notice on the local startup explaining how to start the shell in remote mode.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to