reswqa commented on code in PR #45: URL: https://github.com/apache/flink-connector-pulsar/pull/45#discussion_r1186787331
########## flink-connector-pulsar/archunit-violations/f4d91193-72ba-4ce4-ad83-98f780dce581: ########## @@ -10,3 +10,15 @@ org.apache.flink.connector.pulsar.source.PulsarSourceITCase does not satisfy: on * reside in a package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class InternalMiniClusterExtension\ * reside outside of package 'org.apache.flink.runtime.*' and is annotated with @ExtendWith with class MiniClusterExtension\ or contain any fields that are public, static, and of type MiniClusterWithClientResource and final and annotated with @ClassRule or contain any fields that is of type MiniClusterWithClientResource and public and final and not static and annotated with @Rule +org.apache.flink.connector.pulsar.sink.PulsarSinkITCase does not satisfy: only one of the following predicates match:\ Review Comment: The reason why we need to duplicate rather than directly modify is that our CI will support multiple versions of flink? Given that `FLINK-31804` has only been merged into the master(1.18), all external connectors that need to suppress this violation should also have the same problem. Perhaps temporary duplicate is acceptable, as it will continue until the workflow for `flink_version < 1.18` is no longer running. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
