pgaref commented on code in PR #22520: URL: https://github.com/apache/flink/pull/22520#discussion_r1187021736
########## flink-core/src/main/java/org/apache/flink/configuration/PipelineOptions.java: ########## @@ -243,13 +243,22 @@ public class PipelineOptions { .build()); public static final ConfigOption<Boolean> OPERATOR_CHAINING = - key("pipeline.operator-chaining") + key("pipeline.operator-chaining.enabled") .booleanType() .defaultValue(true) + .withDeprecatedKeys("pipeline.operator-chaining") .withDescription( "Operator chaining allows non-shuffle operations to be co-located in the same thread " + "fully avoiding serialization and de-serialization."); + public static final ConfigOption<Boolean> + OPERATOR_CHAINING_CHAIN_OPERATORS_WITH_DIFFERENT_MAX_PARALLELISM = + key("pipeline.operator-chaining.chain-operators-with-different-max-parallelism") + .booleanType() + .defaultValue(true) + .withDescription( + "Operators with different max parallelism can be chained together."); Review Comment: Shall we add a note here like: `Default behavior may prevent rescaling when the AdaptiveScheduler is used` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org