reswqa commented on code in PR #24541: URL: https://github.com/apache/flink/pull/24541#discussion_r1566978504
########## flink-datastream/src/main/java/org/apache/flink/datastream/impl/stream/ProcessConfigurableDataStream.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.datastream.impl.stream; + +import org.apache.flink.api.common.operators.SlotSharingGroup; +import org.apache.flink.api.common.operators.util.OperatorValidationUtils; +import org.apache.flink.api.dag.Transformation; +import org.apache.flink.datastream.api.stream.ProcessConfigurable; +import org.apache.flink.datastream.impl.ExecutionEnvironmentImpl; +import org.apache.flink.streaming.api.datastream.DataStream; + +/** A {@link DataStream} implementation which processing configurable. */ +@SuppressWarnings("unchecked") +public class ProcessConfigurableDataStream<T, S extends ProcessConfigurable<S>> Review Comment: You're totally right, binding configuration to streams is something we wanted to avoid in the first place, even at the implementation level. I have refactored the design here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
