csviri commented on code in PR #816:
URL: 
https://github.com/apache/flink-kubernetes-operator/pull/816#discussion_r1567338233


##########
flink-kubernetes-operator-api/src/main/java/org/apache/flink/kubernetes/operator/api/validation/CrdCompatibilityChecker.java:
##########
@@ -93,7 +93,10 @@ protected static void checkObjectCompatibility(
                     // This field was removed from Kubernetes ObjectMeta v1 in 
1.25 as it was unused
                     // for a long time. If set for any reason (very unlikely 
as it does nothing),
                     // the property will be dropped / ignored by the api 
server.
-                    if (!fieldPath.endsWith(".metadata.clusterName")) {
+                    if (!fieldPath.endsWith(".metadata.clusterName")
+                            // This field was removed from the pod templates 
when upgrading
+                            // from crd-generator 6.8 to 6.11, needs further 
assessment
+                            && 
!fieldPath.contains(".volumeClaimTemplate.spec.resources.claims")) {

Review Comment:
   This field was removed from Kubernetes API: 
https://github.com/kubernetes/api/blob/master/core/v1/types.go#L2620-L2625



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to