mas-chen commented on code in PR #24564:
URL: https://github.com/apache/flink/pull/24564#discussion_r1568044466
##########
docs/static/generated/rest_v1_dispatcher.yml:
##########
@@ -1089,6 +1089,37 @@ paths:
application/json:
schema:
$ref: '#/components/schemas/JobVertexBackPressureInfo'
+ /jobs/{jobid}/vertices/{vertexid}/coordinator-metrics:
+ get:
+ description: Provides access to job manager operator metrics
Review Comment:
Yes it should, but my question is more about the scope of the endpoint and
this feature.
If a user wants other JM operator metrics in the future, what would happen?
1. We would need to support another endpoint (possibly deprecate this one
and create a new one that supports all JM operator metrics)
2. Integrate with the Flink UI again
Also, the feedback from @zentol and @lindong28 in [1] reflects that the devs
were against `coordinator-metrics` and introducing a specific scope to support
that, and perhaps that feedback also applies to this REST API. I had this as my
original proposal in the voting thread for the FLIP to support
`/jobs/.../vertices/.../jm-operator-metrics`. The endpoint path doesn't change
anything fundamentally in this PR
[1] https://lists.apache.org/thread/hdvz57wmlqxdxgnw73tcgbcfyo6vk09h
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
