morazow commented on code in PR #3230:
URL: https://github.com/apache/flink-cdc/pull/3230#discussion_r1569850914
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-cdc-base/src/main/java/org/apache/flink/cdc/connectors/base/source/meta/split/StreamSplit.java:
##########
@@ -163,10 +163,18 @@ public String toString() {
// -------------------------------------------------------------------
public static StreamSplit appendFinishedSplitInfos(
StreamSplit streamSplit, List<FinishedSnapshotSplitInfo>
splitInfos) {
+ // re-calculate the starting changelog offset after the new table added
+ Offset startingOffset = streamSplit.getStartingOffset();
+ for (FinishedSnapshotSplitInfo splitInfo : splitInfos) {
+ if (splitInfo.getHighWatermark().isBefore(startingOffset)) {
+ startingOffset = splitInfo.getHighWatermark();
+ }
+ }
Review Comment:
Do we have to distinguish the high watermarks before the startingOffset? For
example, if there are multiple high watermarks before startingOffset, which one
should we take? Should it be the latest of those?
Or is taking any highWatermark if it is before the startingOffset is
allright?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@flink.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
