[ https://issues.apache.org/jira/browse/HBASE-21160?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16614570#comment-16614570 ]
Ted Yu commented on HBASE-21160: -------------------------------- Can you address these ? {code} [WARNING] /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java:[94,9] [CatchFail] Ignoring exceptions and calling fail() is unnecessary, and makes test output less useful [WARNING] /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java:[183,9] [CatchFail] Ignoring exceptions and calling fail() is unnecessary, and makes test output less useful [WARNING] /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java:[195,71] [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments [WARNING] /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java:[196,74] [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments [WARNING] /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDefaultVisLabelService.java:[197,77] [DefaultCharset] Implicit use of the platform default charset, which can result in e.g. non-ASCII characters being silently replaced with '?' in many environments {code} > Assertion in > TestVisibilityLabelsWithDeletes#testDeleteColumnsWithoutAndWithVisibilityLabels > is ignored > ------------------------------------------------------------------------------------------------------- > > Key: HBASE-21160 > URL: https://issues.apache.org/jira/browse/HBASE-21160 > Project: HBase > Issue Type: Test > Reporter: Ted Yu > Assignee: liubangchen > Priority: Trivial > Attachments: HBASE-21160-1.patch > > > From > https://builds.apache.org/job/PreCommit-HBASE-Build/14327/artifact/patchprocess/diff-compile-javac-hbase-server.txt > (HBASE-21138 QA run): > {code} > [WARNING] > /testptch/hbase/hbase-server/src/test/java/org/apache/hadoop/hbase/security/visibility/TestVisibilityLabelsWithDeletes.java:[315,25] > [AssertionFailureIgnored] This assertion throws an AssertionError if it > fails, which will be caught by an enclosing try block. > {code} > Here is related code: > {code} > PrivilegedExceptionAction<Void> scanAction = new > PrivilegedExceptionAction<Void>() { > @Override > public Void run() throws Exception { > try (Connection connection = > ConnectionFactory.createConnection(conf); > ... > assertEquals(1, next.length); > } catch (Throwable t) { > throw new IOException(t); > } > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005)