[ 
https://issues.apache.org/jira/browse/HBASE-21285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16645138#comment-16645138
 ] 

Ted Yu commented on HBASE-21285:
--------------------------------

In TableSnapshotInputFormatImpl#getRegionSizes, snapshot visitor may encounter 
IOExceptiion.
{code}
+    Map<String, Long> regionSizes = getRegionSizes(conf, fs, snapshotDir);
{code}
Please add protection against potential IOExceptiion.

As I mentioned above, if the additional computation takes non-trivial amount of 
time, we should consider introducing new config for the improvement.

> Enhanced TableSnapshotInputFormat to allow a size based splitting
> -----------------------------------------------------------------
>
>                 Key: HBASE-21285
>                 URL: https://issues.apache.org/jira/browse/HBASE-21285
>             Project: HBase
>          Issue Type: Improvement
>          Components: snapshots
>    Affects Versions: 1.4.0
>            Reporter: Lavinia-Stefania Sirbu
>            Priority: Minor
>         Attachments: HBASE-21285.branch-1.4.001.patch
>
>
> Currently, all the splits generated by a snapshot are having length 0. Right 
> now, we have a configuration for the number of splits per region, but it's a 
> general one and not very helpful when the sizes for regions are really 
> different. The modification must be done in TableSnapshotInputFormatImpl 
> where the length must be computed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to