[ 
https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638994#comment-16638994
 ] 

Ted Yu edited comment on HBASE-21246 at 10/10/18 3:56 PM:
----------------------------------------------------------

The first question is addressed by patch v2 which drops the method.

The abstraction of WAL identity should allow all backends (hdfs, Ratis, Kafka) 
to express the information the underlying backend carries for each WAL.
e.g. for Kafka backend, we can use topic to represent region, the partitions 
under the topic would correspond to the WALs for the region.
Therefore a String alone doesn't have as much expressibility as an interface.

That is why we chose to use an interface to represent WAL identity.


was (Author: yuzhih...@gmail.com):
Now that design doc is back to review mode, please allow some more time till I 
address the above comment.

> Introduce WALIdentity interface
> -------------------------------
>
>                 Key: HBASE-21246
>                 URL: https://issues.apache.org/jira/browse/HBASE-21246
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Major
>         Attachments: 21246.HBASE-20952.001.patch, 21246.HBASE-20952.002.patch
>
>
> We are introducing WALIdentity interface so that the WAL representation can 
> be decoupled from distributed filesystem.
> The interface provides getName method whose return value can represent 
> filename in distributed filesystem environment or, the name of the stream 
> when the WAL is backed by log stream.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to