[
https://issues.apache.org/jira/browse/HBASE-21247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647993#comment-16647993
]
Ted Yu commented on HBASE-21247:
--------------------------------
bq. in v6 you still have two different places that try to load by classname
Can you point out where the second place is ? There is only one call to
{{Class.forName}} in WALFactory after the patch.
bq. you should be using conf.getClass
The second and third parameters of getClass are of type Class. For the purpose
of this JIRA, the class of the custom WAL provider is not known before
{{Class.forName}} is called. That was why I used {{conf.get}}
bq. Why does the one after the enum get the wrong name?
Can you point to the place in code (not sure what 'the one after the enum'
refers to) ?
The last 3 questions were about test failures for patch v6.
I ran these tests locally with patch which passed.
> Custom WAL Provider cannot be specified by configuration whose value is
> outside the enums in Providers
> ------------------------------------------------------------------------------------------------------
>
> Key: HBASE-21247
> URL: https://issues.apache.org/jira/browse/HBASE-21247
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: 21247.v1.txt, 21247.v2.txt, 21247.v3.txt, 21247.v4.tst,
> 21247.v4.txt, 21247.v5.txt, 21247.v6.txt
>
>
> Currently all the WAL Providers acceptable to hbase are specified in
> Providers enum of WALFactory.
> This restricts the ability for additional WAL Providers to be supplied - by
> class name.
> This issue fixes the bug by allowing the specification of new WAL Provider
> class name using the config "hbase.wal.provider".
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
