[ https://issues.apache.org/jira/browse/HBASE-21246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653646#comment-16653646 ]
Ted Yu commented on HBASE-21246: -------------------------------- When making relevant changes in replication related classes, I came upon the following in ZKReplicationQueueStorage#claimQueue() : {code} List<String> wals = ZKUtil.listChildrenNoWatch(zookeeper, oldQueueNode); {code} We are supposed to obtain WALIdentity's by deserializing what's stored in zookeeper. This is where the {{createWALIdentity(String)}} method comes into play. The respective WALProvider implementation has knowledge on how to deserialize the String form of WAL Id into WALIdentity. e.g. the String form of WAL Id can be "/topic/partition" for the Kafka backed WALProvider. > Introduce WALIdentity interface > ------------------------------- > > Key: HBASE-21246 > URL: https://issues.apache.org/jira/browse/HBASE-21246 > Project: HBase > Issue Type: Sub-task > Reporter: Ted Yu > Assignee: Ted Yu > Priority: Major > Fix For: HBASE-20952 > > Attachments: 21246.003.patch, 21246.HBASE-20952.001.patch, > 21246.HBASE-20952.002.patch, 21246.HBASE-20952.004.patch, > 21246.HBASE-20952.005.patch > > > We are introducing WALIdentity interface so that the WAL representation can > be decoupled from distributed filesystem. > The interface provides getName method whose return value can represent > filename in distributed filesystem environment or, the name of the stream > when the WAL is backed by log stream. -- This message was sent by Atlassian JIRA (v7.6.3#76005)