[ 
https://issues.apache.org/jira/browse/HBASE-25449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17261583#comment-17261583
 ] 

Josh Elser commented on HBASE-25449:
------------------------------------

Tested this on branch-2 and master, locally, just to make sure the metrics from 
HBASE-8868 align. branch-2.4 works fine (with Hadoop 3.1.2), but master looks a 
little weird. I'm not entirely convinced it's a problem – it may just be us 
being smarter and I've not yet caught up. I was able to observe 
shortCircuitBytesRead in the logs with master, so I believe the config is 
correct in that respect (and something is just happening that obviates any read 
from HDFS).

Either way, pushing this now.

> 'dfs.client.read.shortcircuit' should not be set in hbase-default.xml
> ---------------------------------------------------------------------
>
>                 Key: HBASE-25449
>                 URL: https://issues.apache.org/jira/browse/HBASE-25449
>             Project: HBase
>          Issue Type: Improvement
>          Components: conf
>    Affects Versions: 2.0.1
>            Reporter: shenshengli
>            Assignee: shenshengli
>            Priority: Major
>
> I think this parameter is not suitable for in hbase-default.xml, because in 
> this case, HDFS explicitly set to "dfs.client.read.shortcircuit=true", hbase 
> rely on HDFS configuration, the parameters in hbase service still is 
> false.Must be explicitly in hbase-site.xml is set to 
> "dfs.client.read.shortcircuit=true" to take effect.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to