[GitHub] [hbase] tomscut commented on a diff in pull request #4431: HBASE-27036 Displays the number of decommissioned region server for status command

[GitBox]

tomscut commented on code in PR #4431:
URL: https://github.com/apache/hbase/pull/4431#discussion_r879053398


##########
hbase-shell/src/main/ruby/hbase/admin.rb:
##########
@@ -1043,6 +1043,7 @@ def status(format, type)
       else
         puts "1 active master, #{cluster_metrics.getBackupMasterNames.size} 
backup masters,
               #{cluster_metrics.getLiveServerMetrics.size} servers,
+              #{@admin.listDecommissionedRegionServers.size} decommissioned,

Review Comment:
   > Cluster metrics approach is better than calling additional admin API 
(includes a separate RPC).
   > 
   > Decommissioned and draining RegionServers are same,
   > 
   > 
https://github.com/apache/hbase/blob/1be2c83b3dc8306050f67828c9c2e361f19481c6/hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java#L3821
   > 
   > Add decommissioned/draining RegionServer to ClusterMetrics class, 
currently it is not there.
   
   Thanks @pankaj72981 for your comments. I found `drainingRegionServers` 
already exist, we can see HBASE-25460. Do you mean to change 
`drainingRegionServers` to `decommissionedRegionServers `?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org