[ 
https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17541004#comment-17541004
 ] 

Szabolcs Bukros commented on HBASE-26969:
-----------------------------------------

[~wchevreuil] 

> Or is it that we lingering region dirs even after the parent SPLIT/MERGE got 
>removed from META?

Yes. these regions are clean up by a chore and linger after no longer used. But 
this does not really matter. The problem is that when we can not easily 
identify which region should contain references to a given MOB file we have 
absolutely no way to tell and have to read every single hfile's metadata to 
check for references.

[~zhangduo] 

> we do not use SFT at all the MOB regions

That is true. We do not use SFT. But based on similar changes the renames would 
be only eliminated if SFT is enabled, not by default. Also it relies on 
WriterCreationTracker which is mostly an SFT tool.

> Eliminate MOB renames when SFT is enabled
> -----------------------------------------
>
>                 Key: HBASE-26969
>                 URL: https://issues.apache.org/jira/browse/HBASE-26969
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mob
>    Affects Versions: 2.5.0, 3.0.0-alpha-3
>            Reporter: Szabolcs Bukros
>            Assignee: Szabolcs Bukros
>            Priority: Major
>             Fix For: 2.6.0, 3.0.0-alpha-3
>
>
> MOB file compaction and flush still relies on renames even when SFT is 
> enabled.
> My proposed changes are:
>  * when requireWritingToTmpDirFirst is false during mob flush/compact instead 
> of using the temp writer we should create a different writer using a 
> {color:#000000}StoreFileWriterCreationTracker that writes directly to the mob 
> store folder{color}
>  * {color:#000000}these StoreFileWriterCreationTracker should be stored in 
> the MobStore. This would requires us to extend MobStore with a createWriter 
> and a finalizeWriter method to handle this{color}
>  * {color:#000000}refactor {color}MobFileCleanerChore to run on the RS 
> instead on Master to allow access to the 
> {color:#000000}StoreFileWriterCreationTracker{color}s to make sure the 
> currently written files are not cleaned up



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to