[
https://issues.apache.org/jira/browse/HIVE-26756?focusedWorklogId=828347&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828347
]
ASF GitHub Bot logged work on HIVE-26756:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/22 12:24
Start Date: 23/Nov/22 12:24
Worklog Time Spent: 10m
Work Description: szlta commented on code in PR #3778:
URL: https://github.com/apache/hive/pull/3778#discussion_r1030379645
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java:
##########
@@ -2698,6 +2699,13 @@ public Table getTable(GetTableRequest getTableRequest)
throws MetaException, TEx
}
}
+ private void extractTablePropertiesFromHook(Table t) throws MetaException {
Review Comment:
Why do we need this method? I guess the only reason is to have the hook
presence check around postGetTable call. Maybe we could rename this that has
nothing to do with properties? Implementors of postGetTable might have a
different reason for implementing than property adjustments.
Issue Time Tracking
-------------------
Worklog Id: (was: 828347)
Time Spent: 1h 10m (was: 1h)
> Iceberg: Fetch format version from metadata file to avoid conflicts with spark
> ------------------------------------------------------------------------------
>
> Key: HIVE-26756
> URL: https://issues.apache.org/jira/browse/HIVE-26756
> Project: Hive
> Issue Type: Bug
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Spark & other engines don't set the format version for iceberg table in the
> HMS properties, which leads to misinterpretation of iceberg format & lead to
> wrong query results.
> Propose to extract the format version from the metadata file always rather
> than relying on the HMS properties.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
