[
https://issues.apache.org/jira/browse/HIVE-26767?focusedWorklogId=828357&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828357
]
ASF GitHub Bot logged work on HIVE-26767:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/22 12:48
Start Date: 23/Nov/22 12:48
Worklog Time Spent: 10m
Work Description: tthorpeIBM commented on PR #3799:
URL: https://github.com/apache/hive/pull/3799#issuecomment-1325007263
The error in testing doesn't look to be anything related to my changes. The
error is from post processing on split-16:
#!/bin/bash -e # removes all stdout and err for passed tests xmlstarlet ed
-L -d 'testsuite/testcase/system-out[count(../failure)=0]' -d
'testsuite/testcase/system-err[count(../failure)=0]' `find . -name 'TEST*xml'
-path '*/surefire-reports/*'` # remove all output.txt files find . -name
'*output.txt' -path '*/surefire-reports/*' -exec unlink "{}" \;
— Shell Script
2s
#!/bin/bash -e tar -czf split-16.tgz --files-from <(find . -path
'*/surefire-reports/*')
— Shell Script
1s
#!/bin/bash -e rsync -rltDq --stats split-16.tgz
rsync://rsync/data/precommit3.split-16.tgz
— Shell Script
<1s
**/TEST-*.xml
— Archive JUnit-formatted test results
5s
[2022-11-23T03:26:22.208Z] Recording test results
[2022-11-23T03:26:27.071Z] [Checks API] No suitable checks publisher found.
Issue Time Tracking
-------------------
Worklog Id: (was: 828357)
Time Spent: 50m (was: 40m)
> Support for custom RDBMS is broken
> ----------------------------------
>
> Key: HIVE-26767
> URL: https://issues.apache.org/jira/browse/HIVE-26767
> Project: Hive
> Issue Type: Bug
> Components: Metastore
> Affects Versions: 4.0.0
> Reporter: Tim Thorpe
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> HIVE-24120 introduced code to support custom RDBMS.
> DatabaseProduct.getDbType(String productName) will return *DbType.UNDEFINED*
> for anything other than the hardcoded/internally supported database types.
> When initializing DatabaseProduct with an external/custom RDBMS, it follows
> this logic:
>
> boolean isExternal = MetastoreConf.getBoolVar(conf,
> ConfVars.USE_CUSTOM_RDBMS);
> if (isExternal) {
> // The DatabaseProduct will be created by instantiating an external
> class via
> // reflection. The external class can override any method in the
> current class
> String className = MetastoreConf.getVar(conf,
> ConfVars.CUSTOM_RDBMS_CLASSNAME);
> if (className != null) {
> try {
> theDatabaseProduct = (DatabaseProduct)
> ReflectionUtils.newInstance(Class.forName(className), conf);
> LOG.info(String.format("Using custom RDBMS %s", className));
> dbt = DbType.CUSTOM;
> These 2 database types (DbType.UNDEFINED, DbType.CUSTOM) are then compared to
> each other to make sure they are the same.
>
> Preconditions.checkState(theDatabaseProduct.dbType == getDbType(productName));
>
> [https://github.com/gatorblue/hive/blob/3a65c6cf9cb552e7c34bfb449a419abfde0a58b6/standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java#L80]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
