[ 
https://issues.apache.org/jira/browse/HIVE-26717?focusedWorklogId=839367&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-839367
 ]

ASF GitHub Bot logged work on HIVE-26717:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Jan/23 10:58
            Start Date: 16/Jan/23 10:58
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3935:
URL: https://github.com/apache/hive/pull/3935#discussion_r1071104172


##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorFactory.java:
##########
@@ -99,10 +99,12 @@ public Compactor getCompactor(Table table, HiveConf 
configuration, CompactionInf
         case MINOR:
           return new MmMinorQueryCompactor();
         case MAJOR:
+        case REBALANCE:
+          // REBALANCE COMPACTION on an insert-only table is simply a MAJOR 
compaction. Since there is no ACID row data,
+          // there is no acid row order to keep, and the number of buckets 
cannot be set at all (it will be calculated
+          // and created by TEZ dynamically). Initiator won't schedule 
REBALANCE compactions for insert-only tables,
+          // however users can request it. In these cases we simply fall back 
to MAJOR compaction
           return new MmMajorQueryCompactor();
-        default:

Review Comment:
   why remove this, what if the user mistypes?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 839367)
    Time Spent: 40m  (was: 0.5h)

> Query based Rebalance compaction on insert-only tables
> ------------------------------------------------------
>
>                 Key: HIVE-26717
>                 URL: https://issues.apache.org/jira/browse/HIVE-26717
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: László Végh
>            Assignee: László Végh
>            Priority: Major
>              Labels: ACID, compaction, pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to