martinzink commented on code in PR #1412:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1412#discussion_r978385514
##########
extensions/standard-processors/processors/PutUDP.cpp:
##########
@@ -107,48 +98,48 @@ void PutUDP::onTrigger(core::ProcessContext* context,
core::ProcessSession* cons
return;
}
- const auto nonthrowing_sockaddr_ntop = [](const sockaddr* const sa) ->
std::string {
- return utils::try_expression([sa] { return utils::net::sockaddr_ntop(sa);
}).value_or("(n/a)");
+ asio::io_context io_context;
+
+ const auto resolve_hostname = [&io_context, &hostname, &port]() ->
nonstd::expected<udp::resolver::results_type, std::error_code> {
+ udp::resolver resolver(io_context);
+ std::error_code error_code;
+ auto resolved_query = resolver.resolve(udp::v4(), hostname, port,
error_code);
+ if (error_code)
+ return nonstd::make_unexpected(error_code);
+ return resolved_query;
+ };
+
+ const auto debug_log_resolved_endpoint = [&hostname, &logger =
this->logger_](const udp::resolver::results_type& resolved_query) ->
udp::endpoint {
+ if (logger->should_log(core::logging::LOG_LEVEL::debug))
+ core::logging::LOG_DEBUG(logger) << "resolved " << hostname << " to: "
<< resolved_query->endpoint();
+ return resolved_query->endpoint();
Review Comment:
I've reworked this part (and also ListenTCP, ListenSyslog) in
https://github.com/apache/nifi-minifi-cpp/pull/1412/commits/aba9c5bb58f317143a6301e1552087c8f6d4a5fa
##########
extensions/standard-processors/processors/PutUDP.cpp:
##########
@@ -107,48 +98,48 @@ void PutUDP::onTrigger(core::ProcessContext* context,
core::ProcessSession* cons
return;
}
- const auto nonthrowing_sockaddr_ntop = [](const sockaddr* const sa) ->
std::string {
- return utils::try_expression([sa] { return utils::net::sockaddr_ntop(sa);
}).value_or("(n/a)");
+ asio::io_context io_context;
+
+ const auto resolve_hostname = [&io_context, &hostname, &port]() ->
nonstd::expected<udp::resolver::results_type, std::error_code> {
+ udp::resolver resolver(io_context);
+ std::error_code error_code;
+ auto resolved_query = resolver.resolve(udp::v4(), hostname, port,
error_code);
+ if (error_code)
+ return nonstd::make_unexpected(error_code);
+ return resolved_query;
+ };
+
+ const auto debug_log_resolved_endpoint = [&hostname, &logger =
this->logger_](const udp::resolver::results_type& resolved_query) ->
udp::endpoint {
+ if (logger->should_log(core::logging::LOG_LEVEL::debug))
+ core::logging::LOG_DEBUG(logger) << "resolved " << hostname << " to: "
<< resolved_query->endpoint();
+ return resolved_query->endpoint();
};
- const auto debug_log_resolved_names = [&, this](const addrinfo& names) ->
decltype(auto) {
- if (logger_->should_log(core::logging::LOG_LEVEL::debug)) {
- std::vector<std::string> names_vector;
- for (const addrinfo* it = &names; it; it = it->ai_next) {
- names_vector.push_back(nonthrowing_sockaddr_ntop(it->ai_addr));
- }
- logger_->log_debug("resolved \'%s\' to: %s",
- hostname,
- names_vector | ranges::views::join(',') | ranges::to<std::string>());
- }
- return names;
+ const auto send_data_to_endpoint = [&io_context, &data](const udp::endpoint&
endpoint) -> nonstd::expected<void, std::error_code> {
+ std::error_code send_error;
+ udp::socket socket(io_context);
+ socket.open(udp::v4());
Review Comment:
I've reworked this part (and also ListenTCP, ListenSyslog) in
https://github.com/apache/nifi-minifi-cpp/pull/1412/commits/aba9c5bb58f317143a6301e1552087c8f6d4a5fa
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
