[
https://issues.apache.org/jira/browse/SPARK-2761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14136061#comment-14136061
]
Jim Lim commented on SPARK-2761:
--------------------------------
I saw some duplicate code in `#maybeSpill` and `#spill` - this PR only deals
with `#maybeSpill`. Not too satisfied with the casting, but I couldn't think of
nice way to workaround it.
> Merge similar code paths in ExternalSorter and EAOM
> ---------------------------------------------------
>
> Key: SPARK-2761
> URL: https://issues.apache.org/jira/browse/SPARK-2761
> Project: Spark
> Issue Type: Improvement
> Affects Versions: 1.1.0
> Reporter: Andrew Or
> Fix For: 1.2.0
>
>
> Right now there is quite a lot of duplicate code. It would be good to merge
> these somehow if we want to make changes to them in the future.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
