[ 
https://issues.apache.org/jira/browse/SPARK-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15628853#comment-15628853
 ] 

Jeff Antes edited comment on SPARK-16808 at 11/2/16 12:46 PM:
--------------------------------------------------------------

One possible solution is in the 
/core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala. 
{code:java}
  private[history] def getAttemptURI(appId: String, attemptId: Option[String]): 
String = {
    val attemptSuffix = attemptId.map { id => s"/$id" }.getOrElse("")
    
UIUtils.prependBaseUri(s"${HistoryServer.UI_PATH_PREFIX}/${appId}${attemptSuffix}")
 
  }
{code}
In the 1.6.x line of code the UIUtils.prependBaseUri was positioned where this 
method was called.  The rewrite removed it.  Fixing it here appears to be 
better semantically.


was (Author: jantes):
One possible solution is in the 
/core/src/main/scala/org/apache/spark/deploy/history/HistoryServer.scala. 

  private[history] def getAttemptURI(appId: String, attemptId: Option[String]): 
String = {
    val attemptSuffix = attemptId.map { id => s"/$id" }.getOrElse("")
    
UIUtils.prependBaseUri(s"${HistoryServer.UI_PATH_PREFIX}/${appId}${attemptSuffix}")
 
  }

In the 1.6.x line of code the UIUtils.prependBaseUri was positioned where this 
method was called.  The rewrite removed it.  Fixing it here appears to be 
better semantically.

> History Server main page does not honor APPLICATION_WEB_PROXY_BASE
> ------------------------------------------------------------------
>
>                 Key: SPARK-16808
>                 URL: https://issues.apache.org/jira/browse/SPARK-16808
>             Project: Spark
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Michael Gummelt
>
> The root of the history server is rendered dynamically with javascript, and 
> this doesn't honor APPLICATION_WEB_PROXY_BASE: 
> https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html#L67
> Other links in the history server do honor it: 
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/UIUtils.scala#L146
> This means the links on the history server root page are broken when deployed 
> behind a proxy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to