[
https://issues.apache.org/jira/browse/SPARK-23435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16513416#comment-16513416
]
Felix Cheung commented on SPARK-23435:
--------------------------------------
sorry, I did try but couldn't get it to work, but something like this?
{code:java}
# for testthat after 1.0.2 call test_dir as run_tests is removed.
if (packageVersion("testthat") >= "2.0.0") {
test_pkg_env <- list2env(as.list(getNamespace("SparkR"), all.names = TRUE),
parent = parent.env(getNamespace("SparkR")))
withr::local_options(list(topLevelEnvironment = test_pkg_env))
test_dir(file.path(sparkRDir, "pkg", "tests", "fulltests"),
env = test_pkg_env,
stop_on_failure = TRUE,
stop_on_warning = FALSE)
} else {
testthat:::run_tests("SparkR",
file.path(sparkRDir, "pkg", "tests", "fulltests"),
NULL,
"summary")
}
{code}
> R tests should support latest testthat
> --------------------------------------
>
> Key: SPARK-23435
> URL: https://issues.apache.org/jira/browse/SPARK-23435
> Project: Spark
> Issue Type: Bug
> Components: SparkR
> Affects Versions: 2.3.1, 2.4.0
> Reporter: Felix Cheung
> Assignee: Felix Cheung
> Priority: Major
>
> To follow up on SPARK-22817, the latest version of testthat, 2.0.0 was
> released in Dec 2017, and its method has been changed.
> In order for our tests to keep working, we need to detect that and call a
> different method.
> Jenkins is running 1.0.1 though, we need to check if it is going to work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
