Maxim Gekk created SPARK-27031:
----------------------------------

             Summary: Avoid double formatting in timestampToString
                 Key: SPARK-27031
                 URL: https://issues.apache.org/jira/browse/SPARK-27031
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 2.4.0
            Reporter: Maxim Gekk


The method DateTimeUtils.timestampToString performs converting of its input to 
string twice:
- First time by converting microseconds to java.sql.Timestamp and toString: 
https://github.com/apache/spark/blob/8e5f9995cad409799f3646b3d03761a771ea1664/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala#L103
- Second time by using provided formatter: 
https://github.com/apache/spark/blob/8e5f9995cad409799f3646b3d03761a771ea1664/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala#L104

This could be avoided by using specialised TimestampFormatter. 




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to