[ https://issues.apache.org/jira/browse/SPARK-32127?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Xianyin Xin updated SPARK-32127: -------------------------------- Description: [SPARK-30924|https://issues.apache.org/jira/browse/SPARK-30924] adds some check rules for MERGE INTO one of which ensures the first MATCHED clause must have a condition. However, it uses {{MergeAction.children}} in the checking which is not accurate for the case, and it lets the below case pass the check: {code:scala} MERGE INTO testcat1.ns1.ns2.tbl AS target xxx WHEN MATCHED THEN UPDATE SET target.col2 = source.col2 WHEN MATCHED THEN DELETE xxx {code} We should use {{MergeAction.condition}} instead. was: [SPARK-30924|https://issues.apache.org/jira/browse/SPARK-30924] adds some check rules for MERGE INTO one of which ensures the first MATCHED clause must have a condition. However, it uses {MergeAction.children} in the checking which is not accurate for the case, and it lets the below case pass the check: {code:scala} MERGE INTO testcat1.ns1.ns2.tbl AS target xxx WHEN MATCHED THEN UPDATE SET target.col2 = source.col2 WHEN MATCHED THEN DELETE xxx {code} We should use {MergeAction.condition} instead. > Check rules for MERGE INTO should use MergeAction.condition other than > MeregAction.children > ------------------------------------------------------------------------------------------- > > Key: SPARK-32127 > URL: https://issues.apache.org/jira/browse/SPARK-32127 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 3.0.0 > Reporter: Xianyin Xin > Priority: Major > > [SPARK-30924|https://issues.apache.org/jira/browse/SPARK-30924] adds some > check rules for MERGE INTO one of which ensures the first MATCHED clause must > have a condition. However, it uses {{MergeAction.children}} in the checking > which is not accurate for the case, and it lets the below case pass the check: > {code:scala} > MERGE INTO testcat1.ns1.ns2.tbl AS target > xxx > WHEN MATCHED THEN UPDATE SET target.col2 = source.col2 > WHEN MATCHED THEN DELETE > xxx > {code} > We should use {{MergeAction.condition}} instead. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org