[ https://issues.apache.org/jira/browse/SPARK-5610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14307599#comment-14307599 ]
Sean Owen commented on SPARK-5610: ---------------------------------- >From looking at the Javadoc 8 + unidoc issue, I recall that we had a problem >where {{private[foo]}} classes were being rendered as private top-level Java >classes, which isn't legal to Javadoc 8. This bit of code you change is the >bit that fixed that particular problem. Is this going to cause such classes to >be private again? that's feels a bit wrong, since such classes aren't really >meaningful in Java anyway. You can certainly tell javadoc to only generate docs for public / protected classes. In fact that should be the default. So I wonder if the right-er change is to render such classes as package-private in Java? it doesn't mean quite the same thing but may be entirely close enough for genjavadoc purposes. > Generate Java docs without package private classes and methods > -------------------------------------------------------------- > > Key: SPARK-5610 > URL: https://issues.apache.org/jira/browse/SPARK-5610 > Project: Spark > Issue Type: Documentation > Components: Documentation > Reporter: Xiangrui Meng > Assignee: Xiangrui Meng > > The current generated Java doc is a mixed of public and package private > classes and methods. We can update genjavadoc to hide them. > Upstream PR: https://github.com/typesafehub/genjavadoc/pull/47 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org