[
https://issues.apache.org/jira/browse/SPARK-19450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17257091#comment-17257091
]
Zhongwei Zhu edited comment on SPARK-19450 at 12/31/20, 7:58 PM:
-----------------------------------------------------------------
For old askWithRetry method, it can use provided config `spark.rpc.numRetries`
and `spark.rpc.retry.wait`. The default value for `spark.rpc.numRetries` is 3.
So I suppose it will retry 3 times if rpc failed, but now askSync is used
without using above 2 configs. Could we support such retry? If retry is
disabled intentionally, maybe doc need to be updated. [~jinxing6...@126.com]
[~srowen]
was (Author: warrenzhu25):
For old askWithRetry method, it can use provided config `spark.rpc.numRetries`
and `spark.rpc.retry.wait`. The default value for `spark.rpc.numRetries` is 3.
So I suppose it will retry 3 times if rpc failed, but now askSync is used
without using above 2 configs. Does that mean no retry anymore?
[~jinxing6...@126.com] [~srowen]
> Replace askWithRetry with askSync.
> ----------------------------------
>
> Key: SPARK-19450
> URL: https://issues.apache.org/jira/browse/SPARK-19450
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 2.1.0
> Reporter: Jin Xing
> Assignee: Jin Xing
> Priority: Minor
> Fix For: 2.2.0
>
>
> *askSync* is already added in *RpcEndpointRef* (see SPARK-19347 and
> https://github.com/apache/spark/pull/16690#issuecomment-276850068) and
> *askWithRetry* is marked as deprecated.
> As mentioned
> SPARK-18113(https://github.com/apache/spark/pull/16503#event-927953218):
> ??askWithRetry is basically an unneeded API, and a leftover from the akka
> days that doesn't make sense anymore. It's prone to cause deadlocks (exactly
> because it's blocking), it imposes restrictions on the caller (e.g.
> idempotency) and other things that people generally don't pay that much
> attention to when using it.??
> Since *askWithRetry* is just used inside spark and not in user logic. It
> might make sense to replace all of them with *askSync*.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
