[ 
https://issues.apache.org/jira/browse/SPARK-39776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

angerszhu updated SPARK-39776:
------------------------------
    Description: 
 Current verbose string don't have joinType


{code:java}
(5) BroadcastHashJoin [codegen id : 8]
Left keys [1]: [ss_sold_date_sk#3]
Right keys [1]: [d_date_sk#5]
Join condition: None
{code}

{code:java}
override def verboseStringWithOperatorId(): String = {
    val joinCondStr = if (condition.isDefined) {
      s"${condition.get}"
    } else "None"
    if (leftKeys.nonEmpty || rightKeys.nonEmpty) {
      s"""
         |$formattedNodeName
         |${ExplainUtils.generateFieldString("Left keys", leftKeys)}
         |${ExplainUtils.generateFieldString("Right keys", rightKeys)}
         |${ExplainUtils.generateFieldString("Join condition", joinCondStr)}
         |""".stripMargin
    } else {
      s"""
         |$formattedNodeName
         |${ExplainUtils.generateFieldString("Join condition", joinCondStr)}
         |""".stripMargin
    }
  }
{code}


  was:
 Current verbose string don't have joinType
{code:java}
override def verboseStringWithOperatorId(): String = {
    val joinCondStr = if (condition.isDefined) {
      s"${condition.get}"
    } else "None"
    if (leftKeys.nonEmpty || rightKeys.nonEmpty) {
      s"""
         |$formattedNodeName
         |${ExplainUtils.generateFieldString("Left keys", leftKeys)}
         |${ExplainUtils.generateFieldString("Right keys", rightKeys)}
         |${ExplainUtils.generateFieldString("Join condition", joinCondStr)}
         |""".stripMargin
    } else {
      s"""
         |$formattedNodeName
         |${ExplainUtils.generateFieldString("Join condition", joinCondStr)}
         |""".stripMargin
    }
  }
{code}



> Join‘ verbose string didn't contains JoinType
> ---------------------------------------------
>
>                 Key: SPARK-39776
>                 URL: https://issues.apache.org/jira/browse/SPARK-39776
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 3.3.0
>            Reporter: angerszhu
>            Priority: Major
>
>  Current verbose string don't have joinType
> {code:java}
> (5) BroadcastHashJoin [codegen id : 8]
> Left keys [1]: [ss_sold_date_sk#3]
> Right keys [1]: [d_date_sk#5]
> Join condition: None
> {code}
> {code:java}
> override def verboseStringWithOperatorId(): String = {
>     val joinCondStr = if (condition.isDefined) {
>       s"${condition.get}"
>     } else "None"
>     if (leftKeys.nonEmpty || rightKeys.nonEmpty) {
>       s"""
>          |$formattedNodeName
>          |${ExplainUtils.generateFieldString("Left keys", leftKeys)}
>          |${ExplainUtils.generateFieldString("Right keys", rightKeys)}
>          |${ExplainUtils.generateFieldString("Join condition", joinCondStr)}
>          |""".stripMargin
>     } else {
>       s"""
>          |$formattedNodeName
>          |${ExplainUtils.generateFieldString("Join condition", joinCondStr)}
>          |""".stripMargin
>     }
>   }
> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to