[
https://issues.apache.org/jira/browse/SPARK-6630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14390350#comment-14390350
]
Sean Owen commented on SPARK-6630:
----------------------------------
This should be as simple as {{ def setIfMissing(key: String, value: =>
String): SparkConf = ... }} if I'm not mistaken about how this works in Scala?
Would you like to make a PR and verify it lazily evaluates? I can't think of a
scenario where it would be important to always evaluate the argument.
> SparkConf.setIfMissing should only evaluate the assigned value if indeed
> missing
> --------------------------------------------------------------------------------
>
> Key: SPARK-6630
> URL: https://issues.apache.org/jira/browse/SPARK-6630
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 1.3.0
> Reporter: Svend Vanderveken
> Priority: Minor
>
> The method setIfMissing() in SparkConf is currently systematically evaluating
> the right hand side of the assignment even if not used. This leads to
> unnecessary computation, like in the case of
> {code}
> conf.setIfMissing("spark.driver.host", Utils.localHostName())
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
