[ 
https://issues.apache.org/jira/browse/SPARK-7320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553073#comment-14553073
 ] 

Patrick Wendell commented on SPARK-7320:
----------------------------------------

Hey [~liancheng] and [~chenghao] - I reverted pull request 6257 because it 
broke all of our maven builds. The issue is that it's not safe to rely on the 
test suite constructor to create the table used in the tests.

Separately, I noticed this JIRA was not closed when the patch was merged. In 
cases like this where the patch only addresses part of the JIRA, it is better 
to just create a sub task or split the task into two different JIRA's. I.e. 
every pull request (ideally) is associated with exactly one JIRA. Otherwise, 
it's difficult to track things like when we revert a patch.

> Add rollup and cube support to DataFrame DSL
> --------------------------------------------
>
>                 Key: SPARK-7320
>                 URL: https://issues.apache.org/jira/browse/SPARK-7320
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>            Reporter: Reynold Xin
>            Assignee: Cheng Hao
>              Labels: starter
>
> We should add two functions to GroupedData in order to support rollup and 
> cube for the DataFrame DSL.
> {code}
> def rollup(): GroupedData
> def cube(): GroupedData
> {code}
> These two should return new GroupedData with the appropriate state set so 
> when we run an Aggregate, we translate the underlying logical operator into 
> Rollup or Cube.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to