[ https://issues.apache.org/jira/browse/SPARK-10576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14742339#comment-14742339 ]
Reynold Xin commented on SPARK-10576: ------------------------------------- Most these files are just package-info.java there for having a good package index for JavaDoc. If we move them, we will need to create a folder in the java one for each package that exposes any documentation. And it is very likely we will forget to update package-info.java when we update package.scala if the two files are far apart. Doesn't seem that big of a deal to have them in Scala folder, and the benefits ain't that big either. > Move .java files out of src/main/scala > -------------------------------------- > > Key: SPARK-10576 > URL: https://issues.apache.org/jira/browse/SPARK-10576 > Project: Spark > Issue Type: Improvement > Components: Build > Affects Versions: 1.5.0 > Reporter: Sean Owen > Priority: Minor > > (I suppose I'm really asking for an opinion on this, rather than asserting it > must be done, but seems worthwhile. CC [~rxin] and [~pwendell]) > As pointed out on the mailing list, there are some Java files in the Scala > source tree: > {code} > ./bagel/src/main/scala/org/apache/spark/bagel/package-info.java > ./core/src/main/scala/org/apache/spark/annotation/AlphaComponent.java > ./core/src/main/scala/org/apache/spark/annotation/DeveloperApi.java > ./core/src/main/scala/org/apache/spark/annotation/Experimental.java > ./core/src/main/scala/org/apache/spark/annotation/package-info.java > ./core/src/main/scala/org/apache/spark/annotation/Private.java > ./core/src/main/scala/org/apache/spark/api/java/package-info.java > ./core/src/main/scala/org/apache/spark/broadcast/package-info.java > ./core/src/main/scala/org/apache/spark/executor/package-info.java > ./core/src/main/scala/org/apache/spark/io/package-info.java > ./core/src/main/scala/org/apache/spark/rdd/package-info.java > ./core/src/main/scala/org/apache/spark/scheduler/package-info.java > ./core/src/main/scala/org/apache/spark/serializer/package-info.java > ./core/src/main/scala/org/apache/spark/util/package-info.java > ./core/src/main/scala/org/apache/spark/util/random/package-info.java > ./external/flume/src/main/scala/org/apache/spark/streaming/flume/package-info.java > ./external/kafka/src/main/scala/org/apache/spark/streaming/kafka/package-info.java > ./external/mqtt/src/main/scala/org/apache/spark/streaming/mqtt/package-info.java > ./external/twitter/src/main/scala/org/apache/spark/streaming/twitter/package-info.java > ./external/zeromq/src/main/scala/org/apache/spark/streaming/zeromq/package-info.java > ./graphx/src/main/scala/org/apache/spark/graphx/impl/EdgeActiveness.java > ./graphx/src/main/scala/org/apache/spark/graphx/lib/package-info.java > ./graphx/src/main/scala/org/apache/spark/graphx/package-info.java > ./graphx/src/main/scala/org/apache/spark/graphx/TripletFields.java > ./graphx/src/main/scala/org/apache/spark/graphx/util/package-info.java > ./mllib/src/main/scala/org/apache/spark/ml/attribute/package-info.java > ./mllib/src/main/scala/org/apache/spark/ml/package-info.java > ./mllib/src/main/scala/org/apache/spark/mllib/package-info.java > ./sql/catalyst/src/main/scala/org/apache/spark/sql/types/SQLUserDefinedType.java > ./sql/hive/src/main/scala/org/apache/spark/sql/hive/package-info.java > ./streaming/src/main/scala/org/apache/spark/streaming/api/java/package-info.java > ./streaming/src/main/scala/org/apache/spark/streaming/dstream/package-info.java > ./streaming/src/main/scala/org/apache/spark/streaming/StreamingContextState.java > {code} > It happens to work since the Scala compiler plugin is handling both. > On its face, they should be in the Java source tree. I'm trying to figure out > if there are good reasons they have to be in this less intuitive location. > I might try moving them just to see. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org