[
https://issues.apache.org/jira/browse/SPARK-11618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14998016#comment-14998016
]
Apache Spark commented on SPARK-11618:
--------------------------------------
User 'jkbradley' has created a pull request for this issue:
https://github.com/apache/spark/pull/9587
> Refactoring of basic ML import/export
> -------------------------------------
>
> Key: SPARK-11618
> URL: https://issues.apache.org/jira/browse/SPARK-11618
> Project: Spark
> Issue Type: Sub-task
> Components: ML
> Reporter: Joseph K. Bradley
> Assignee: Joseph K. Bradley
>
> This is for a few updates to the original PR for basic ML import/export in
> [SPARK-11217].
> * The original PR diverges from the design doc in that it does not include
> the Spark version or a model format version. We should include the Spark
> version in the metadata. If we do that, then we don't really need a model
> format version.
> * Proposal: DefaultParamsWriter includes two separable pieces of logic in
> save(): (a) handling overwriting and (b) saving Params. I want to separate
> these by putting (a) in a save() method in Writer which calls an abstract
> saveImpl, and (b) in the saveImpl implementation in DefaultParamsWriter.
> This is described below:
> {code}
> abstract class Writer {
> def save(path: String) = {
> // handle overwrite
> saveImpl(path)
> }
> def saveImpl(path: String) // abstract
> }
> class DefaultParamsWriter extends Writer {
> def saveImpl(path: String) = {
> // save Params
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
