[
https://issues.apache.org/jira/browse/SPARK-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15010111#comment-15010111
]
Earthson Lu commented on SPARK-6727:
------------------------------------
It’s fine:)
I can give some help when the API is ready.
And I have a suggestion for the DefaultWritable/Readable:
/**
* Default Writable using DefaultParamsWriter
*/
@Experimental
@Since("1.6.0")
trait DefaultWritable extends Writable {
self: Params =>
override def write: Writer = new DefaultParamsWriter(self)
}
/**
* Default Readable using DefaultParamsReader
* @tparam T ML instance type
*/
@Experimental
@Since("1.6.0")
trait DefaultReadable[T] extends Readable[T] {
override def read: Reader[T] = new DefaultParamsReader[T]
}
I don’t know, wether this interface is complicated enough for this trait style.
--
Earthson Lu
On November 17, 2015 at 10:41:11, Joseph K. Bradley (JIRA) (j...@apache.org)
wrote:
[
https://issues.apache.org/jira/browse/SPARK-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15007900#comment-15007900
]
Joseph K. Bradley commented on SPARK-6727:
------------------------------------------
[~EarthsonLu] Apologies for the slow response, but we've been working on adding
this in one big batch in [SPARK-11769]. I appreciate your PR, but would you
mind holding off on working on these export/import JIRAs for a little? We'll
post publicly once they are ready to be taken up; the problem is that we are
still tweaking the API a little as we fill it out. Thank you!
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
> Model export/import for spark.ml: HashingTF
> -------------------------------------------
>
> Key: SPARK-6727
> URL: https://issues.apache.org/jira/browse/SPARK-6727
> Project: Spark
> Issue Type: Sub-task
> Components: ML
> Affects Versions: 1.3.0
> Reporter: Joseph K. Bradley
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
