[ 
https://issues.apache.org/jira/browse/KAFKA-6298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277878#comment-16277878
 ] 

Narendra Kumar commented on KAFKA-6298:
---------------------------------------

I also tested the LocationAwareLogger with log4j and logback bindings , it 
works fine (at least for version '1.7.25').

[~ijuma] If I understood you correctly, you meant: we should not abandon 
LogContext since it is being used in many places, instead LogContext should 
handle this transparently to the user based on the availability of 
LocationAwareLogger api. Right ?

> Line numbers on log messages are incorrect
> ------------------------------------------
>
>                 Key: KAFKA-6298
>                 URL: https://issues.apache.org/jira/browse/KAFKA-6298
>             Project: Kafka
>          Issue Type: Bug
>            Reporter: Colin P. McCabe
>
> The line numbers on log messages are all incorrect now.
> For example, AdminClient should have this log message on line 394:
> {code}
> 394 log.debug("Kafka admin client initialized")
> {code}
> But instead, it shows up as being on line 177:
> {code}
>     [2017-12-01 15:42:18,710] DEBUG [AdminClient clientId=adminclient-1] 
> Kafka admin client initialized 
> (org.apache.kafka.clients.admin.KafkaAdminClient:177)
> {code}
> The line numbers appear to be coming from {{LogContext.java}}:
> {code}
> 174        @Override
> 175        public void debug(String message) {
> 176            if (logger.isDebugEnabled())
> 177                logger.debug(logPrefix + message);
> 178        }
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to