[
https://issues.apache.org/jira/browse/KAFKA-14132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683961#comment-17683961
]
Hector Geraldino commented on KAFKA-14132:
------------------------------------------
Hey [~divijvaidya],
I'm putting together a KIP around
[https://github.com/apache/kafka/pull/13193|https://github.com/apache/kafka/pull/13193,]
in which I'll propose adding new metric counters for filtered (skipped)
records. The POC is code complete, but for it to be ready I need to add new
test cases on *WorkerSinkTaskTest* and *WorkerSinkTaskThreadedTest* unit tests.
These two are assigned to you, and I was wondering if you're OK with me picking
them up, this will unblock my other work. I did the same for
https://issues.apache.org/jira/browse/KAFKA-14659 (had to raise
[https://github.com/apache/kafka/pull/13191] before adding tests for that bug
fix)
Wdyt?
> Remaining PowerMock to Mockito tests
> ------------------------------------
>
> Key: KAFKA-14132
> URL: https://issues.apache.org/jira/browse/KAFKA-14132
> Project: Kafka
> Issue Type: Sub-task
> Reporter: Christo Lolov
> Assignee: Christo Lolov
> Priority: Major
>
> {color:#de350b}Some of the tests below use EasyMock as well. For those
> migrate both PowerMock and EasyMock to Mockito.{color}
> Unless stated in brackets the tests are in the connect module.
> A list of tests which still require to be moved from PowerMock to Mockito as
> of 2nd of August 2022 which do not have a Jira issue and do not have pull
> requests I am aware of which are opened:
> {color:#ff8b00}InReview{color}
> {color:#00875a}Merged{color}
> # {color:#00875a}ErrorHandlingTaskTest{color} (owner: [~shekharrajak])
> # {color:#00875a}SourceTaskOffsetCommiterTest{color} (owner: Christo)
> # {color:#00875a}WorkerMetricsGroupTest{color} (owner: Divij)
> # WorkerSinkTaskTest (owner: Divij) *WIP*
> # WorkerSinkTaskThreadedTest (owner: Divij) *WIP*
> # {color:#00875a}WorkerTaskTest{color} (owner: [~yash.mayya])
> # {color:#00875a}ErrorReporterTest{color} (owner: [~yash.mayya])
> # {color:#00875a}RetryWithToleranceOperatorTest{color} (owner: [~yash.mayya])
> # {color:#00875a}WorkerErrantRecordReporterTest{color} (owner: [~yash.mayya])
> # {color:#00875a}ConnectorsResourceTest{color} (owner: [~mdedetrich-aiven])
> # {color:#ff8b00}StandaloneHerderTest{color} (owner: [~mdedetrich-aiven])
> ([https://github.com/apache/kafka/pull/12728])
> # KafkaConfigBackingStoreTest (owner: [~mdedetrich-aiven])
> # {color:#00875a}KafkaOffsetBackingStoreTest{color} (owner: Christo)
> ([https://github.com/apache/kafka/pull/12418])
> # {color:#ff8b00}KafkaBasedLogTest{color} (owner: [~mdedetrich-aiven])
> # RetryUtilTest (owner: [~mdedetrich-aiven] )
> # {color:#00875a}RepartitionTopicTest{color} (streams) (owner: Christo)
> # {color:#00875a}StateManagerUtilTest{color} (streams) (owner: Christo)
> *The coverage report for the above tests after the change should be >= to
> what the coverage is now.*
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
