kirktrue commented on code in PR #13797:
URL: https://github.com/apache/kafka/pull/13797#discussion_r1223460709
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/ApplicationEventProcessor.java:
##########
@@ -106,4 +114,17 @@ private boolean process(final OffsetFetchApplicationEvent
event) {
manager.addOffsetFetchRequest(event.partitions);
return true;
}
+
+ private boolean process(final MetadataUpdateApplicationEvent event) {
+ metadata.requestUpdateForNewTopics();
+ return true;
+ }
+
+ private boolean process(final UnsubscribeApplicationEvent event) {
+ /*
+ this.coordinator.onLeavePrepare();
+ this.coordinator.maybeLeaveGroup("the consumer unsubscribed
from all topics");
+ */
Review Comment:
Removed those lines as it's for unsubscribe which isn't baked enough for
this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
