dajac commented on code in PR #13880: URL: https://github.com/apache/kafka/pull/13880#discussion_r1243668510
########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/RecordSerdeTest.java: ########## @@ -0,0 +1,260 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.coordinator.group; + +import org.apache.kafka.common.protocol.ApiMessage; +import org.apache.kafka.common.protocol.MessageUtil; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupCurrentMemberAssignmentKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupCurrentMemberAssignmentValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMemberMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupPartitionMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupPartitionMetadataValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMemberValue; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMetadataKey; +import org.apache.kafka.coordinator.group.generated.ConsumerGroupTargetAssignmentMetadataValue; +import org.apache.kafka.coordinator.group.generated.GroupMetadataKey; +import org.apache.kafka.coordinator.group.generated.GroupMetadataValue; +import org.apache.kafka.coordinator.group.generated.OffsetCommitKey; +import org.apache.kafka.coordinator.group.generated.OffsetCommitValue; +import org.apache.kafka.coordinator.group.runtime.CoordinatorLoader; +import org.apache.kafka.server.common.ApiMessageAndVersion; +import org.junit.jupiter.api.Test; + +import java.nio.ByteBuffer; + +import static org.junit.jupiter.api.Assertions.assertArrayEquals; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNull; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.junit.jupiter.api.Assertions.assertTrue; + +public class RecordSerdeTest { + @Test + public void testSerializeKey() { + RecordSerde serializer = new RecordSerde(); + Record record = new Record( + new ApiMessageAndVersion( + new ConsumerGroupMetadataKey().setGroupId("group"), + (short) 1 + ), + new ApiMessageAndVersion( + new ConsumerGroupMetadataValue().setEpoch(10), + (short) 0 + ) + ); + + assertArrayEquals( + MessageUtil.toVersionPrefixedBytes(record.key().version(), record.key().message()), + serializer.serializeKey(record) + ); + } + + @Test + public void testSerializeValue() { + RecordSerde serializer = new RecordSerde(); + Record record = new Record( + new ApiMessageAndVersion( + new ConsumerGroupMetadataKey().setGroupId("group"), + (short) 1 + ), + new ApiMessageAndVersion( + new ConsumerGroupMetadataValue().setEpoch(10), + (short) 0 + ) + ); + + assertArrayEquals( + MessageUtil.toVersionPrefixedBytes(record.value().version(), record.value().message()), + serializer.serializeValue(record) + ); + } + + @Test + public void testSerializeNullValue() { + RecordSerde serializer = new RecordSerde(); + Record record = new Record( + new ApiMessageAndVersion( + new ConsumerGroupMetadataKey().setGroupId("group"), + (short) 1 + ), + null + ); + + assertNull(serializer.serializeValue(record)); + } + + @Test + public void testDeserialize() { + RecordSerde serDe = new RecordSerde(); + + ApiMessageAndVersion key = new ApiMessageAndVersion( + new ConsumerGroupMetadataKey().setGroupId("foo"), + (short) 3 + ); + ByteBuffer keyBuffer = MessageUtil.toVersionPrefixedByteBuffer(key.version(), key.message()); + + ApiMessageAndVersion value = new ApiMessageAndVersion( + new ConsumerGroupMetadataValue().setEpoch(10), + (short) 0 + ); + ByteBuffer valueBuffer = MessageUtil.toVersionPrefixedByteBuffer(value.version(), value.message()); + + Record record = serDe.deserialize(keyBuffer, valueBuffer); + assertEquals(key, record.key()); + assertEquals(value, record.value()); + } + + @Test + public void testDeserializeWithTombstoneForValue() { + RecordSerde serDe = new RecordSerde(); + + ApiMessageAndVersion key = new ApiMessageAndVersion( + new ConsumerGroupMetadataKey().setGroupId("foo"), + (short) 3 + ); + ByteBuffer keyBuffer = MessageUtil.toVersionPrefixedByteBuffer(key.version(), key.message()); + + Record record = serDe.deserialize(keyBuffer, null); + assertEquals(key, record.key()); + assertNull(record.value()); + } + + @Test + public void testDeserializeWithInvalidRecordType() { + RecordSerde serDe = new RecordSerde(); + + ByteBuffer keyBuffer = ByteBuffer.allocate(64); + keyBuffer.putShort((short) 255); + keyBuffer.rewind(); + + ByteBuffer valueBuffer = ByteBuffer.allocate(64); + + CoordinatorLoader.UnknownRecordTypeException ex = + assertThrows(CoordinatorLoader.UnknownRecordTypeException.class, + () -> serDe.deserialize(keyBuffer, valueBuffer)); + assertEquals((short) 255, ex.unknownType()); + } + + @Test + public void testDeserializeWithKeyEmptyBuffer() { + RecordSerde serDe = new RecordSerde(); + + ByteBuffer keyBuffer = ByteBuffer.allocate(0); + ByteBuffer valueBuffer = ByteBuffer.allocate(64); + + RuntimeException ex = + assertThrows(RuntimeException.class, + () -> serDe.deserialize(keyBuffer, valueBuffer)); + assertEquals("Could not read version from key's buffer.", ex.getMessage()); + } + + @Test + public void testDeserializeWithValueEmptyBuffer() { + RecordSerde serDe = new RecordSerde(); + + ApiMessageAndVersion key = new ApiMessageAndVersion( + new ConsumerGroupMetadataKey().setGroupId("foo"), + (short) 3 + ); + ByteBuffer keyBuffer = MessageUtil.toVersionPrefixedByteBuffer(key.version(), key.message()); + + ByteBuffer valueBuffer = ByteBuffer.allocate(0); + + RuntimeException ex = + assertThrows(RuntimeException.class, + () -> serDe.deserialize(keyBuffer, valueBuffer)); + assertEquals("Could not read version from value's buffer.", ex.getMessage()); + } + + @Test + public void testDeserializeWithInvalidKeyBytes() { + RecordSerde serDe = new RecordSerde(); + + ByteBuffer keyBuffer = ByteBuffer.allocate(2); + keyBuffer.putShort((short) 3); + keyBuffer.rewind(); + + ByteBuffer valueBuffer = ByteBuffer.allocate(2); Review Comment: Correct. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
