kirktrue commented on code in PR #13591:
URL: https://github.com/apache/kafka/pull/13591#discussion_r1243795683
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/TransactionManager.java:
##########
@@ -609,7 +673,7 @@ public synchronized void handleCompletedBatch(ProducerBatch
batch, ProduceRespon
}
public synchronized void transitionToUninitialized(RuntimeException
exception) {
- transitionTo(State.UNINITIALIZED);
+ transitionTo(State.UNINITIALIZED, exception);
Review Comment:
Good catch. That was me being sloppy/assumptive. The `transitionTo` doesn't
look at the incoming exception unless the target state is `FATAL_ERROR` or
`ABORTABLE_ERROR`, so this was effectively a no-op anyway 🤷♂️. I've removed
the exception from the call to `transitionTo`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
