jolshan commented on code in PR #13798: URL: https://github.com/apache/kafka/pull/13798#discussion_r1244331034
########## core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala: ########## @@ -17,25 +17,37 @@ package kafka.server +import kafka.server.AddPartitionsToTxnManager.{verificationFailureRateMetricName, verificationTimeMsMetricName} import kafka.utils.Logging import org.apache.kafka.clients.{ClientResponse, NetworkClient, RequestCompletionHandler} import org.apache.kafka.common.{Node, TopicPartition} import org.apache.kafka.common.message.AddPartitionsToTxnRequestData.{AddPartitionsToTxnTransaction, AddPartitionsToTxnTransactionCollection} import org.apache.kafka.common.protocol.Errors import org.apache.kafka.common.requests.{AddPartitionsToTxnRequest, AddPartitionsToTxnResponse} import org.apache.kafka.common.utils.Time +import org.apache.kafka.server.metrics.KafkaMetricsGroup import org.apache.kafka.server.util.{InterBrokerSendThread, RequestAndCompletionHandler} import java.util +import java.util.concurrent.TimeUnit import scala.collection.mutable object AddPartitionsToTxnManager { type AppendCallback = Map[TopicPartition, Errors] => Unit + + val verificationFailureRateMetricName = "VerificationFailureRate" Review Comment: Oh hmm -- so we would have to predefine or lazily create the meters with the various error messages. I'm wondering if this is still necessary. We should be able to figure out the errors from either the api error metrics or from the logging. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org