jolshan commented on code in PR #13901:
URL: https://github.com/apache/kafka/pull/13901#discussion_r1244492766
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -874,4 +1021,34 @@ public void replay(
consumerGroup.updateMember(newMember);
}
}
+
+ /**
+ * A new metadata image is available.
+ *
+ * @param newImage The new metadata image.
+ * @param delta The delta image.
+ */
+ public void onNewMetadataImage(MetadataImage newImage, MetadataDelta
delta) {
+ metadataImage = newImage;
+
+ // Notify all the groups subscribed to the created, updated or
+ // deleted topics.
+ Set<String> allGroupIds = new HashSet<>();
+ delta.topicsDelta().changedTopics().forEach((topicId, topicDelta) -> {
+ String topicName = topicDelta.name();
+ Set<String> groupIds = groupsByTopics.get(topicName);
+ if (groupIds != null) allGroupIds.addAll(groupIds);
+ });
+ delta.topicsDelta().deletedTopicIds().forEach(topicId -> {
+ TopicImage topicImage = delta.image().topics().getTopic(topicId);
+ Set<String> groupIds = groupsByTopics.get(topicImage.name());
+ if (groupIds != null) allGroupIds.addAll(groupIds);
Review Comment:
we don't want to add all the deleted topics do we?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
