johnnychhsu commented on code in PR #15488:
URL: https://github.com/apache/kafka/pull/15488#discussion_r1517940750


##########
core/src/test/scala/unit/kafka/log/LogLoaderTest.scala:
##########
@@ -352,7 +353,10 @@ class LogLoaderTest {
       // Intercept all segment read calls
       val interceptedLogSegments = new LogSegments(topicPartition) {
         override def add(segment: LogSegment): LogSegment = {
-          val wrapper = new LogSegment(segment) {
+          val idx = 
LazyIndex.forOffset(LogFileUtils.offsetIndexFile(wrapperLogDir, 
segment.baseOffset()), segment.baseOffset(), 1000)

Review Comment:
   learnt a new framework for testing, thanks for sharing this! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to