chia7712 commented on code in PR #15474: URL: https://github.com/apache/kafka/pull/15474#discussion_r1518065927
########## tools/src/test/java/org/apache/kafka/tools/GetOffsetShellTest.java: ########## @@ -52,20 +55,30 @@ public class GetOffsetShellTest { private final int topicCount = 4; private final int offsetTopicPartitionCount = 4; private final ClusterInstance cluster; + private final String topicName = "topic"; public GetOffsetShellTest(ClusterInstance cluster) { this.cluster = cluster; } private String getTopicName(int i) { - return "topic" + i; + return topicName + i; } - public void setUp() { + @BeforeEach + public void before(TestInfo testInfo) { Review Comment: > So while it is ok to configure via the flush method -- let's make the record size smaller. We should confirm the batching is as expected when we run the tests. :) +1 to this comment 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org