jolshan commented on code in PR #15486:
URL: https://github.com/apache/kafka/pull/15486#discussion_r1518065460
##########
core/src/main/scala/kafka/server/AddPartitionsToTxnManager.scala:
##########
@@ -49,7 +49,8 @@ object AddPartitionsToTxnManager {
*/
class TransactionDataAndCallbacks(val transactionData:
AddPartitionsToTxnTransactionCollection,
val callbacks: mutable.Map[String,
AddPartitionsToTxnManager.AppendCallback],
- val startTimeMs: mutable.Map[String, Long])
+ val startTimeMs: mutable.Map[String, Long],
+ val produceRequestVersion: Short)
Review Comment:
nice this is what I was thinking 👍
I noticed that this is a bit tricky for the offset commit path. We will want
a given request version there too, but the versions don't map quite the same. I
will think a bit on how to address this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
