chia7712 commented on code in PR #15502:
URL: https://github.com/apache/kafka/pull/15502#discussion_r1518650689
##########
core/src/main/scala/kafka/network/RequestChannel.scala:
##########
@@ -258,7 +258,11 @@ object RequestChannel extends Logging {
m.responseSendTimeHist.update(Math.round(responseSendTimeMs))
m.totalTimeHist.update(Math.round(totalTimeMs))
m.requestBytesHist.update(sizeOfBodyInBytes)
-
m.messageConversionsTimeHist.foreach(_.update(Math.round(messageConversionsTimeMs)))
+ m.messageConversionsTimeHist.foreach(h => {
+ if (messageConversionsTimeMs > 0) {
Review Comment:
This is a kind of behavior change. Could you add comments for it? Also, we
should have unit test to verify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
