CalvinConfluent commented on code in PR #14706:
URL: https://github.com/apache/kafka/pull/14706#discussion_r1520115442
##########
metadata/src/main/java/org/apache/kafka/controller/ReplicationControlManager.java:
##########
@@ -2240,6 +2283,25 @@ private void updatePartitionDirectories(
}
}
+ private void updatePartitionInfo(
+ Uuid topicId,
+ Integer partitionId,
+ PartitionRegistration prevPartInfo,
+ PartitionRegistration newPartInfo
+ ) {
+ HashSet<Integer> validationSet = new HashSet<>();
+ Arrays.stream(newPartInfo.isr).forEach(ii -> validationSet.add(ii));
+ Arrays.stream(newPartInfo.elr).forEach(ii -> validationSet.add(ii));
+ if (validationSet.size() != newPartInfo.isr.length +
newPartInfo.elr.length) {
+ log.warn("{}-{} has overlapping ISR={} and ELR={}",
topics.get(topicId).name, partitionId,
+ Arrays.toString(newPartInfo.isr), partitionId,
Arrays.toString(newPartInfo.elr));
Review Comment:
Correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
