lianetm commented on code in PR #15511:
URL: https://github.com/apache/kafka/pull/15511#discussion_r1525446624
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/MembershipManagerImplTest.java:
##########
@@ -1028,9 +1028,9 @@ public void
testNewEmptyAssignmentReplacesPreviousOneWaitingOnMetadata() {
verifyReconciliationNotTriggered(membershipManager);
membershipManager.poll(time.milliseconds());
+ membershipManager.onHeartbeatRequestSent();
Review Comment:
I would suggest we add the check that a reconciliation was triggered here,
just adding
`verifyReconciliationTriggeredAndCompleted(membershipManager,
Collections.emptyList());` right after poll. It's part of what this PR is
introducing and it completes the pic of what's happening when getting the first
(empty) assignment that can be reconciled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
