[ 
https://issues.apache.org/jira/browse/KAFKA-16231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kirk True updated KAFKA-16231:
------------------------------
    Description: 
This task is to update {{consumer_test.py}} to support the {{group.protocol}} 
configuration introduced in 
[KIP-848|https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol]
 by adding an optional {{group_protocol}} argument to the tests and matrixes.

For example, here's how it would look to add the new group_protocol parameter 
to the parameterized tests:
{code:python}
    @cluster(num_nodes=6)
    @matrix(
        assignment_strategy=["org.apache.kafka.clients.consumer.RangeAssignor",
                             
"org.apache.kafka.clients.consumer.RoundRobinAssignor",
                             
"org.apache.kafka.clients.consumer.StickyAssignor"], 
        metadata_quorum=[quorum.zk, quorum.isolated_kraft],
        use_new_coordinator=[False]
    )
    @matrix(
        metadata_quorum=[quorum.isolated_kraft],
        use_new_coordinator=[True],
        group_protocol=["classic", "consumer"]
    )
    def test_the_consumer(self, assignment_strategy, metadata_quorum=quorum.zk, 
use_new_coordinator=False, group_protocol="classic"):
        consumer = self.setup_consumer("my_topic", 
group_protocol=group_protocol)
{code}
The {{group_protocol}} parameter will default to {{{}classic{}}}.

{*}Note{*}: we only test the new group protocol setting when 
{{use_new_coordinator}} is {{{}True{}}}, as that is the only supported mode.

  was:
This task is to update {{consumer_test.py}} to support the {{group.protocol}} 
configuration introduced in 
[KIP-848|https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol]
 by adding an optional {{group_protocol}} argument to the tests and matrixes.

For example, here's how it would look to add the new group_protocol parameter 
to the parameterized tests:
{code:python}
    @cluster(num_nodes=6)
    @matrix(
        assignment_strategy=["org.apache.kafka.clients.consumer.RangeAssignor",
                             
"org.apache.kafka.clients.consumer.RoundRobinAssignor",
                             
"org.apache.kafka.clients.consumer.StickyAssignor"], 
        metadata_quorum=[quorum.zk],
        use_new_coordinator=[False]
    )
    @matrix(
        assignment_strategy=["org.apache.kafka.clients.consumer.RangeAssignor",
                             
"org.apache.kafka.clients.consumer.RoundRobinAssignor",
                             
"org.apache.kafka.clients.consumer.StickyAssignor"], 
        metadata_quorum=[quorum.isolated_kraft],
        use_new_coordinator=[False]
    )
    @matrix(
        metadata_quorum=[quorum.isolated_kraft],
        use_new_coordinator=[True],
        group_protocol=["classic", "consumer"]
    )
    def test_the_consumer(self, assignment_strategy, metadata_quorum=quorum.zk, 
use_new_coordinator=False, group_protocol="classic"):
        consumer = self.setup_consumer("my_topic", 
group_protocol=group_protocol)
{code}
The {{group_protocol}} parameter will default to {{{}classic{}}}.

{*}Note{*}: we only test the new group protocol setting when 
{{use_new_coordinator}} is {{{}True{}}}, as that is the only supported mode.


> Update consumer_test.py to support KIP-848’s group protocol config
> ------------------------------------------------------------------
>
>                 Key: KAFKA-16231
>                 URL: https://issues.apache.org/jira/browse/KAFKA-16231
>             Project: Kafka
>          Issue Type: Test
>          Components: clients, consumer, system tests
>    Affects Versions: 3.7.0
>            Reporter: Kirk True
>            Assignee: Kirk True
>            Priority: Blocker
>              Labels: kip-848-client-support, system-tests
>             Fix For: 3.8.0
>
>
> This task is to update {{consumer_test.py}} to support the {{group.protocol}} 
> configuration introduced in 
> [KIP-848|https://cwiki.apache.org/confluence/display/KAFKA/KIP-848%3A+The+Next+Generation+of+the+Consumer+Rebalance+Protocol]
>  by adding an optional {{group_protocol}} argument to the tests and matrixes.
> For example, here's how it would look to add the new group_protocol parameter 
> to the parameterized tests:
> {code:python}
>     @cluster(num_nodes=6)
>     @matrix(
>         
> assignment_strategy=["org.apache.kafka.clients.consumer.RangeAssignor",
>                              
> "org.apache.kafka.clients.consumer.RoundRobinAssignor",
>                              
> "org.apache.kafka.clients.consumer.StickyAssignor"], 
>         metadata_quorum=[quorum.zk, quorum.isolated_kraft],
>         use_new_coordinator=[False]
>     )
>     @matrix(
>         metadata_quorum=[quorum.isolated_kraft],
>         use_new_coordinator=[True],
>         group_protocol=["classic", "consumer"]
>     )
>     def test_the_consumer(self, assignment_strategy, 
> metadata_quorum=quorum.zk, use_new_coordinator=False, 
> group_protocol="classic"):
>         consumer = self.setup_consumer("my_topic", 
> group_protocol=group_protocol)
> {code}
> The {{group_protocol}} parameter will default to {{{}classic{}}}.
> {*}Note{*}: we only test the new group protocol setting when 
> {{use_new_coordinator}} is {{{}True{}}}, as that is the only supported mode.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to