dongnuo123 commented on code in PR #15593:
URL: https://github.com/apache/kafka/pull/15593#discussion_r1542011267
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -760,6 +776,28 @@ public ClassicGroup classicGroup(
}
}
+ public boolean validateOnlineUpgrade(ClassicGroup classicGroup) {
+ return
GroupProtocolMigrationPolicy.isUpgradeEnabled(groupProtocolMigrationPolicy) &&
+ !classicGroup.isInState(DEAD) &&
+
ConsumerProtocol.PROTOCOL_TYPE.equals(classicGroup.protocolType().orElse(null))
&&
+ classicGroup.size() <= consumerGroupMaxSize;
+ }
+
+ ConsumerGroup convertToConsumerGroup(ClassicGroup classicGroup,
List<Record> records) {
+ classicGroup.completeAllJoinFutures(Errors.REBALANCE_IN_PROGRESS);
+ classicGroup.completeAllSyncFutures(Errors.REBALANCE_IN_PROGRESS);
+ createGroupTombstoneRecords(classicGroup, records);
+ ConsumerGroup consumerGroup = new ConsumerGroup(snapshotRegistry,
classicGroup.groupId(), metrics);
+ classicGroup.convertToConsumerGroup(consumerGroup, records,
metadataImage.topics());
+
+ // Manually trigger a rebalance.
Review Comment:
Maybe it's not necessary to trigger the rebalance here. If the consumer
restarts and joins the group as a new member, the group epoch will always be
bumped in consumerGroupHeartbeat.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
